OK.. this has taken me a while to figure out.
Defines passed in using
export PLATFORMIO_BUILD_FLAGS="-DMY_MELVANIMATE_GIT_TAG=$MYMELGIT -DESPMANAGER_GIT_TAG=$MANGIT -DMELVANIMATE_GIT_TAG=$MELGIT"
actually overwrite the build flags defined in the platformio.ini file. This is why my sketches stopped working all of a sudden! and I could not for the life of me figure out why!!!
I need these defined platformio.ini to also persist
build_flags = -Wl,-Tesp8266.flash.4m.ld -DDEBUG_DEVICE -DWS2812_UART_METHOD -DDebug_ESPManager=Serial
hence the SPIFFS flash config not working.
Is this intended behaviour or is there away to add build flags, not overwrite them?