Try downloading the library (modbus-esp8266) into your lib folder (so that lib/modbus-esp8266) exists, then declare lib_deps = modbus-esp8266 in your platformio.ini instead of your previous declaration. Remove the entire .pio folder (to get a clean build) and press the build button. Does that throw any errors?