Linter errors in Atom

electrotwelve · November 15, 2019, 1:40am

I have a platformio project (Marlin 2.0 firmware) that I’m trying to compile in Atom + platformio. The firmware compiles just fine, however, I keep seeing errors in Linter (as seen below). I uninstalled platformio and then Atom and then reinstalled everything and I still see the same errors. What am I missing? This is on a macOS Mojave 10.14.6.

maxgerhardt · November 15, 2019, 12:42pm

These errors are very valid, because the Configuration.h file does not do a include <macros.h> at the beginning of the file (source).This file contains the needed macros

github.com

MarlinFirmware/Marlin/blob/0f57818f2decca8340fd5fc86f9ea7b792d9d802/Marlin/src/core/macros.h#L167-L179


      
          #define _CAT(a,V...) a##V
          #define CAT(a,V...) _CAT(a,V)
          #define SWITCH_ENABLED_false 0
          #define SWITCH_ENABLED_true  1
          #define SWITCH_ENABLED_0     0
          #define SWITCH_ENABLED_1     1
          #define SWITCH_ENABLED_0x0   0
          #define SWITCH_ENABLED_0x1   1
          #define SWITCH_ENABLED_      1
          #define _ENA_1(O)           _CAT(SWITCH_ENABLED_, O)
          #define _DIS_1(O)           !_ENA_1(O)
          #define ENABLED(V...)       DO(ENA,&&,V)
          #define DISABLED(V...)      DO(DIS,&&,V)

It still compiles because they include macros.h before the Configuration.h, so it gets fixed up last minute. By itself, Configuration.h is ‘incomplete’ so to say.

github.com

MarlinFirmware/Marlin/blob/0f57818f2decca8340fd5fc86f9ea7b792d9d802/Marlin/src/inc/MarlinConfigPre.h#L31-L37


      
          #include <stdint.h>
          
          
#include "../HAL/platforms.h"
          
          
#include "../core/boards.h"
          #include "../core/macros.h"
          #include "../../Configuration.h"

TL;DR: valid linter error in the context of just looking at this file. Also this the linter extension complaining and not even PIO.

electrotwelve · November 15, 2019, 2:15pm

Thanks. This was helpful. I was not aware this is not a PIO issue. It is very strange that these errors do not show up with the same project on another machine.

maxgerhardt · November 15, 2019, 2:55pm

Same Atom and C++/Linter extension version?

electrotwelve · November 23, 2019, 7:01am

Its the same version there too. However, I just noticed that if I make edits to the configuration.h the errors and warnings immediately start showing. Thanks for clearing this up for me.