The end is near for that dreaded keyboard focus bug

pfeerick · November 20, 2019, 9:04am

Looks like that nasty bug in VSCode that has been stealing keyboard focus, and generating numberous forum posts, is near to being squashed. It was found to be an upstream Chromium issue, and is in the process of being included in Electron, so hopefully we’ll see it in the next update to VSCode.

github.com/microsoft/vscode

WebViewPanel created with preserveFocus: true suffers from a focus problem.

opened 10:20AM - 08 Jul 19 UTC

closed 07:33PM - 21 Nov 19 UTC

tamuratak

bug help wanted verified candidate webview electron upstream-issue-fixed

- VSCode Version: Version: 1.37.0-insider Commit: d50852db1af10ec100a71ad57cc3a…04c8aead117 Date: 2019-07-08T05:33:31.335Z Electron: 4.2.5 Chrome: 69.0.3497.128 Node.js: 10.11.0 V8: 6.9.427.31-electron.0 OS: Darwin x64 17.7.0 - OS Version: macOS High Sierra 10.13.6 (17G7024) Steps to Reproduce: 1. Execute the following sample code of extension. 2. Execute the `Hello World` command. 2. Click the tab of WebView and press the `f` key of the keyboard. 3. In the conlose, only the `window focused!` message shown. 4. Click the tab of WebView, again. Then, press `f`. 5. The message `keyboard F typed!` shown. ![Jul-08-2019 19-18-51](https://user-images.githubusercontent.com/10665499/60803049-46c55200-a1b5-11e9-833a-5a20f80725b6.gif) ```typescript import * as vscode from 'vscode'; export function activate(context: vscode.ExtensionContext) { const rootUrl = vscode.Uri.file(context.extensionPath) const disposable = vscode.commands.registerCommand('extension.helloWorld', async (args, brgs, crgs) => { if (!vscode.window.activeTextEditor) { return; } const panel = vscode.window.createWebviewPanel( 'catCoding', 'Cat Coding', { preserveFocus: true, viewColumn: vscode.ViewColumn.Beside }, { enableScripts: true } ); panel.webview.html = getHtml(); }); context.subscriptions.push(disposable); } function getHtml() { return ` <!DOCTYPE html><html><head></head> <body> <script> window.onfocus = function() { console.log('window focused!'); } window.addEventListener('keydown', function(evt) { if(evt.keyCode == 70 && evt.target.nodeName != 'INPUT') { console.log('keyboard F typed!') } }) </script> ` } // this method is called when your extension is deactivated export function deactivate() {} ``` Does this issue occur when all extensions are disabled?: Yes

ivankravets · November 20, 2019, 4:34pm

Yes, we already contacted Microsoft. They are impressed with our success for PlatformIO IDE extension and promised us to close issues related to PlatformIO. I don’t know how many weeks/months we will need for this.

pfeerick · November 22, 2019, 1:43am

Yabba Dabba Doo!

deepak1556: the fix is now available in latest insiders
txase: I already checked earlier today. Works beautifully!

pfeerick · November 26, 2019, 10:48am

And the fix is now live for all… VSCode 1.40.2 includes the fix! So make sure you update, if you don’t want to have to keep double-clicking the home tab to use your keyboard!